A few comments to make it a bit clearer what this is all about.

http://gwt-code-reviews.appspot.com/76803/diff/1/2
File samples/mail/src/com/google/gwt/sample/mail/client/Contacts.java
(right):

http://gwt-code-reviews.appspot.com/76803/diff/1/2#newcode84
Line 84: @UiField ComplexPanel panel;
Reflects a change in the .ui.xml structure.

http://gwt-code-reviews.appspot.com/76803/diff/1/3
File samples/mail/src/com/google/gwt/sample/mail/client/Contacts.ui.xml
(right):

http://gwt-code-reviews.appspot.com/76803/diff/1/3#newcode14
Line 14: </g:FlowPanel>
Added the extra FlowPanel for the padding. Turns out that adding a
padding style to tables on IE7 causes it to go crazy and add padding
around every td.

http://gwt-code-reviews.appspot.com/76803/diff/1/4
File samples/mail/src/com/google/gwt/sample/mail/client/MailList.java
(left):

http://gwt-code-reviews.appspot.com/76803/diff/1/4#oldcode59
Line 59: table.setWidth("100%");
This is duplicated below. Copy/paste mistake.

http://gwt-code-reviews.appspot.com/76803/diff/1/5
File samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml
(right):

http://gwt-code-reviews.appspot.com/76803/diff/1/5#newcode3
Line 3: >
Necessary to get &nbsp;

http://gwt-code-reviews.appspot.com/76803/diff/1/5#newcode37
Line 37: &nbsp;
Separates the two widgets. Apparently a little normal whitespace wasn't
enough on IE.

http://gwt-code-reviews.appspot.com/76803/diff/1/6
File samples/mail/war/Mail.html (right):

http://gwt-code-reviews.appspot.com/76803/diff/1/6#newcode2
Line 2:
Believe it or not, this is entirely legitimate and correct (c.f.
http://ejohn.org/blog/html5-doctype/).

http://gwt-code-reviews.appspot.com/76803/diff/1/7
File user/src/com/google/gwt/layout/client/LayoutImpl.java (right):

http://gwt-code-reviews.appspot.com/76803/diff/1/7#newcode58
Line 58: style.setHeight(10, heightUnit);
Needed to make rulers 10x larger to get a little extra resolution. This
is necessary because I just discovered that IE allows the possibility of
non-integral unit values. Other browsers don't seem to do this.

http://gwt-code-reviews.appspot.com/76803/diff/1/7#newcode115
Line 115: return fixedRuler.getOffsetWidth() / 23.6;
All these are simply multiplied by 10.

http://gwt-code-reviews.appspot.com/76803/diff/1/8
File user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
(right):

http://gwt-code-reviews.appspot.com/76803/diff/1/8#newcode100
Line 100: getElement().getStyle().setBackgroundColor("white");
If the background-color is 'default', IE7 doesn't fire any mouse events
on it. Go figure.

http://gwt-code-reviews.appspot.com/76803

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to