Reviewers: jgw, Message: I'm looking for an initial vetting of the overall idea, not necessarily this implementation. Obviously, there are additional entry-points that need to be reworked and $entry need to detect reentrancy.
Description: This is an attempt to rationalize how external JS code should call into a GWT module. A new module-level variable $entry will be defined to provide a wrapper function that will correctly enter and exit GWT code. Previously, where you might have written: $wnd.foo = @some.package.Class::staticMethod(typeArgs); you would now write $wnd.foo = $entry(@some.package.Class::staticMethod(typeArgs)); Right now, $entry just makes sure that the uncaught exception handler is called. Later on, it will ensure that the FinallyCommand stack gets flushed (e.g. to allow for efficient batching of StyleInjector calls). Please review this at http://gwt-code-reviews.appspot.com/77810 Affected files: M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java M dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java M dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java M user/src/com/google/gwt/core/client/impl/Impl.java M user/src/com/google/gwt/user/client/impl/DOMImplMozilla.java M user/src/com/google/gwt/user/client/impl/DOMImplStandard.java M user/src/com/google/gwt/user/client/impl/DOMImplTrident.java --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---