JUnitShell and RunStyles LGTM Just a couple of nits.
http://gwt-code-reviews.appspot.com/77818/diff/1/43 File user/src/com/google/gwt/junit/JUnitShell.java (left): http://gwt-code-reviews.appspot.com/77818/diff/1/43#oldcode557 Line 557: if (unitTestShell.thread != Thread.currentThread()) { This was added intentionally to ensure we don't run a test outside of the main thread that created JUnitShell. It may not matter anymore because it was handling an exception in SWT Display, which is now gone. http://gwt-code-reviews.appspot.com/77818/diff/1/42 File user/src/com/google/gwt/junit/RunStyleHtmlUnit.java (right): http://gwt-code-reviews.appspot.com/77818/diff/1/42#newcode198 Line 198: getLogger().log(TreeLogger.WARN, "RunStyleHtmlUnit: Ignoring unknown " This should throw an ERROR. The WARN can be lost in the output, and a user may not even realize that they accidently typed the wrong browser name. http://gwt-code-reviews.appspot.com/77818 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
