Hi Frank,

The farewellSwt branch is no longer active. John merged it back in trunk in
r6366. Can you update this patch to be against trunk, post r6366? Also, can
you double-check if the comments for tests that no longer use @DoNotRunWith
need to be updated?

Thanks,
Amit

On Tue, Oct 13, 2009 at 5:47 PM, <f...@google.com> wrote:

> Reviewers: amitmanjhi,
>
> Description:
> @DoNotRunWith({Platform.Htmlunit}) is the one gating the Htmlunit test
> cases that failed. Since bug fixes in GWT and HtmlUnit, some of these
> annotated test case are already passing. Need to remove these
> annotations.
>
> Please review this at http://gwt-code-reviews.appspot.com/78815
>
> Affected files:
>  user/test/com/google/gwt/dev/jjs/test/RunAsyncMetricsIntegrationTest.java
>  user/test/com/google/gwt/dom/client/ElementTest.java
>  user/test/com/google/gwt/dom/client/MapTests.java
>  user/test/com/google/gwt/dom/client/NodeTest.java
>  user/test/com/google/gwt/event/dom/client/DomEventTest.java
>  user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java
>  user/test/com/google/gwt/user/client/rpc/UnicodeEscapingTest.java
>  user/test/com/google/gwt/user/client/ui/AnchorTest.java
>  user/test/com/google/gwt/user/client/ui/ButtonTest.java
>  user/test/com/google/gwt/user/client/ui/CheckBoxTest.java
>  user/test/com/google/gwt/user/client/ui/CreateEventTest.java
>  user/test/com/google/gwt/user/client/ui/DOMTest.java
>  user/test/com/google/gwt/user/client/ui/DialogBoxTest.java
>  user/test/com/google/gwt/user/client/ui/HistoryTest.java
>  user/test/com/google/gwt/user/client/ui/ImageTest.java
>  user/test/com/google/gwt/user/client/ui/MenuBarTest.java
>  user/test/com/google/gwt/user/client/ui/PopupTest.java
>  user/test/com/google/gwt/user/client/ui/SimpleRadioButtonTest.java
>  user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
>  user/test/com/google/gwt/user/client/ui/TreeTest.java
>  user/test/com/google/gwt/xml/client/XMLTest.java
>
>
>

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to