LGTM - I agree with Tamplin's comments on the package location.  It's
been a while, but com.google.gwt.dev.shell.remoteui would seem like a
reasonable package location to me.


http://gwt-code-reviews.appspot.com/78825/diff/1/2
File dev/oophm/src/com/google/gwt/dev/shell/log/remotemessage.proto
(right):

http://gwt-code-reviews.appspot.com/78825/diff/1/2#newcode1
Line 1: package com.google.gwt.dev.shell.log;
Nit: Add copyright header.

http://gwt-code-reviews.appspot.com/78825/diff/1/2#newcode5
Line 5: message Message {
Nit: Add doc comments for the messages and enums.

http://gwt-code-reviews.appspot.com/78825

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to