http://gwt-code-reviews.appspot.com/80801/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/flow/ClInitPruner.java
(right):

http://gwt-code-reviews.appspot.com/80801/diff/1/2#newcode63
Line 63: tracer.inc(Tracing.COUNT_PRUNABLE_CLINIT);
Everything looks beautiful except here.  Where is the clinit actually
removed?  Is BasicBlock going to have some methods for doing
modification, I suppose?

http://gwt-code-reviews.appspot.com/80801/diff/1/2#newcode64
Line 64: } else if (clinit != null) {
To my taste, check for nullness before calling contains().  It's a
little easier to understand what's going on.  It's up to you, though.

http://gwt-code-reviews.appspot.com/80801

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to