http://gwt-code-reviews.appspot.com/80805/diff/1/2 File dev/core/src/com/google/gwt/dev/shell/remoteui/DevModeServiceServer.java (right):
http://gwt-code-reviews.appspot.com/80805/diff/1/2#newcode55 Line 55: public void handleRequest(Request request) { This queues a request, it doesn't necessarily handle it. Should this method be enqueueRequest or addRequest? http://gwt-code-reviews.appspot.com/80805/diff/1/2#newcode83 Line 83: System.err.println("Unknown DevModeRequest type: " Should return unknown request type. http://gwt-code-reviews.appspot.com/80805/diff/1/2#newcode99 Line 99: capabilityExchangeBuilder = capabilityExchangeBuilder.setCapability(i, Don't you want to encode these as the enum values instead or their backing numbers? http://gwt-code-reviews.appspot.com/80805/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/MessageProcessor.java (right): http://gwt-code-reviews.appspot.com/80805/diff/1/3#newcode211 Line 211: public void sendResponseMessage(Message.Response responseMessage) FWIW, you would not need this method if at all if processing a request simply returned a Result object. http://gwt-code-reviews.appspot.com/80805/diff/1/6 File dev/core/src/com/google/gwt/dev/shell/remoteui/remotemessage.proto (right): http://gwt-code-reviews.appspot.com/80805/diff/1/6#newcode187 Line 187: message CapabilityExchange { You will also want to think about whether there is any other additional information that you want to send along for each supported response type. http://gwt-code-reviews.appspot.com/80805/diff/1/6#newcode188 Line 188: repeated uint32 capability = 1; You should be able to declare this as a repeates ViewerRequest.RequestType. That seems to work for me in some other test code that I have. http://gwt-code-reviews.appspot.com/80805/diff/1/6#newcode219 Line 219: message CapabilityExchange { That should work. See comment on line 188. http://gwt-code-reviews.appspot.com/80805 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
