One or two questions, and I can't really answer most of the FIXME issues--some or all of the others will need to pick those up.
Thanks for this! http://gwt-code-reviews.appspot.com/86801/diff/1/9 File dev/core/src/com/google/gwt/dev/generator/ast/MethodCall.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/9#newcode26 Line 26: // FIXME - arguments is set but never read FIXME instead of suppressed b/c you're not positive it's used? http://gwt-code-reviews.appspot.com/86801/diff/1/15 File dev/core/src/com/google/gwt/dev/js/JsHoister.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/15#newcode75 Line 75: for (JsExpression dummy : x.getExpressions()) { Wouldn't it be better to do something like Iterator i = x.getExpressions().iterator(); while (i.hasNext()) { ... } http://gwt-code-reviews.appspot.com/86801/diff/1/11 File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java (left): http://gwt-code-reviews.appspot.com/86801/diff/1/11#oldcode558 Line 558: + intfMethod.toString(); Why is it okay to delete this? http://gwt-code-reviews.appspot.com/86801/diff/1/26 File user/src/com/google/gwt/core/client/GWT.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/26#newcode212 Line 212: @SuppressWarnings("unused") // name parameter will be used following replacement line too long (sorry) http://gwt-code-reviews.appspot.com/86801/diff/1/40 File user/src/com/google/gwt/layout/client/LayoutImplIE6.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/40#newcode289 Line 289: @SuppressWarnings("unused") // called frmo JSNI frmo http://gwt-code-reviews.appspot.com/86801/diff/1/34 File user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/34#newcode418 Line 418: // FIXME - can the typeOracle parameter be removed? Yes. Generator code is Java code, real Java. If the parm looks unused, it's unused. http://gwt-code-reviews.appspot.com/86801/diff/1/33 File user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/33#newcode72 Line 72: // FIXME - is the (Object) cast actually necessary? Isn't this a clue that toReturn is declared wrong? Shouldn't it be Map<String, ? extends Object> to allow the cast to go away? http://gwt-code-reviews.appspot.com/86801/diff/1/24 File user/src/com/google/gwt/rpc/client/impl/ClientWriterFactory.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/24#newcode64 Line 64: @SuppressWarnings("unused") // typeOverrides param is used by super-source peer Line too long. "See super-source peer", I think we'd all get it. http://gwt-code-reviews.appspot.com/86801/diff/1/31 File user/src/com/google/gwt/uibinder/rebind/FieldWriterOfGeneratedType.java (left): http://gwt-code-reviews.appspot.com/86801/diff/1/31#oldcode25 Line 25: FieldWriter { Oops, thanks. http://gwt-code-reviews.appspot.com/86801/diff/1/29 File user/src/com/google/gwt/uibinder/sample/client/HandlerDemo.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/29#newcode69 Line 69: @SuppressWarnings("unused") What a shame. I wonder if there is anyway we can make @UiHandler itself imply this? Surprised to see this needed on a non-private method. And why only this one? http://gwt-code-reviews.appspot.com/86801/diff/1/64 File user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/64#newcode148 Line 148: public void updateRightWidth(Element rightElem, int newRightWidth) { Could mention that its an override point for subclasses. http://gwt-code-reviews.appspot.com/86801/diff/1/44 File user/src/com/google/gwt/user/datepicker/client/CalendarUtil.java (right): http://gwt-code-reviews.appspot.com/86801/diff/1/44#newcode53 Line 53: @SuppressWarnings("deprecation") // use deprecated Date methods instead of Calendar Long line. How about "GWT requires Date"? http://gwt-code-reviews.appspot.com/86801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
