Mostly LGTM, with only wording/translation issues.
http://gwt-code-reviews.appspot.com/86804/diff/1/7 File samples/showcase/src/com/google/gwt/sample/showcase/client/ShowcaseConstants.properties (right): http://gwt-code-reviews.appspot.com/86804/diff/1/7#newcode187 Line 187: cwPluralFormsExampleDescription = Interface Messages provides a way to create strongly-typed parameterized messages that are checked for correctness during compilation. The wording seems awkward here, and doesn't actually mention plural forms. http://gwt-code-reviews.appspot.com/86804/diff/1/11 File samples/showcase/src/com/google/gwt/sample/showcase/client/content/i18n/PluralMessages_ar.properties (right): http://gwt-code-reviews.appspot.com/86804/diff/1/11#newcode16 Line 16: # TODO(jlabanca): We need real translations. Not just real translations, but the proper plural forms as well. For Arabic, you need the following: none - count is 0 one - count is 1 two - count is 2 few - last two digits of count is 03-10 many - last two digits of count is 11-99 I think this shouldn't get checked in until we have the proper translations/plural forms. http://gwt-code-reviews.appspot.com/86804/diff/1/9 File samples/showcase/src/com/google/gwt/sample/showcase/client/content/i18n/PluralMessages_zh.properties (right): http://gwt-code-reviews.appspot.com/86804/diff/1/9#newcode16 Line 16: # TODO(jlabanca): We need real translations. In most cases, there are no plural forms in Chinese. Unless this is the exception, there should only be a treeCount entry below. I think we should have the correct translation before checking this in. http://gwt-code-reviews.appspot.com/86804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
