Reviewers: scottb, Description: Now that we've admitted htmlunit isn't quite ready, but all other tests require "odd" property assignments, people should be warned that they maybe didn't run the testing they thought they did.
I thought about getting fancy and testing the -D's and making a more specific message, but regardless we should warn that htmlunit *didn't* run, so the message works out to very minor variations anyway (between "no user tests ran" and "only a subset user tests ran") Please review this at http://gwt-code-reviews.appspot.com/86809 Affected files: build.xml user/build.xml Index: build.xml =================================================================== --- build.xml (revision 6483) +++ build.xml (working copy) @@ -112,6 +112,11 @@ <call-subproject subproject="user" subtarget="test" /> <call-subproject subproject="servlet" subtarget="test" /> <call-subproject subproject="tools" subtarget="test" /> + <!--TODO: remove this echo (and from user/build.xml) once it's untrue --> + <echo message="WARNING: htmlunit has been suppressed as unstable, and DID NOT RUN."/> + <echo message=" Remote user tests ran per -Dgwt.hosts.*.remote or"/> + <echo message=" -Dgwt.remote.browsers, and/or -Dgwt.hosts.*.selenium"/> + <echo message=" or -Dgwt.selenium.hosts, but that's all."/> </target> <path id="emma.classpath.src"> Index: user/build.xml =================================================================== --- user/build.xml (revision 6483) +++ user/build.xml (working copy) @@ -464,6 +464,8 @@ <!-- <antcall target="test.web.htmlunit"/> --> <!-- <antcall target="test.draft.htmlunit"/> --> <!-- <antcall target="test.nometa.htmlunit"/> --> + <!-- TODO(jlabanca): remove this echo (and from toplevel) once it's untrue --> + <echo message="WARNING: htmlunit has been suppressed as unstable, and DID NOT RUN."/> </parallel> </limit> </target> --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
