The + -0 case won't optimize because there isn't unary operator optimizer that will treat negative zero as zero. On 2009/10/28 13:41:31, bobv wrote: > http://gwt-code-reviews.appspot.com/88803/diff/1/2 > File dev/core/src/com/google/gwt/dev/js/JsStaticEval.java (right):
> http://gwt-code-reviews.appspot.com/88803/diff/1/2#newcode417 > Line 417: > Extra whitespace. > http://gwt-code-reviews.appspot.com/88803/diff/1/2#newcode495 > Line 495: } > As a sanity check, add an assertion that the returned string is numerically > equal to the incoming string. > http://gwt-code-reviews.appspot.com/88803/diff/1/2#newcode584 > Line 584: if (arg1 instanceof JsNumberLiteral) { > Extract this set of if statements into another private method to avoid > repetition below: > boolean appendLiteral(StringBuilder, JsValueLiteral) > returns true if the value was successfully appended. > Also, add support for null and boolean literals? > http://gwt-code-reviews.appspot.com/88803/diff/1/3 > File dev/core/test/com/google/gwt/dev/js/JsStaticEvalTest.java (right): > http://gwt-code-reviews.appspot.com/88803/diff/1/3#newcode29 > Line 29: > Add: > alert(42.0 + 'Hello') > alert('Hello' + -0) http://gwt-code-reviews.appspot.com/88803 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
