Reviewers: scottb, Description: Two issues here, both arguably ant bugs. Although the scripts have correct perms, and <zip> creates a non-executable copy unless you explicitly set fileperm in the <zipfileset>. That gets you a "correct" build/dist/gwt-X.X.X.zip, and unzip will do the right thing with it... but ant <unzip> again gives you non-executable files (?!, ant 1.7.1), so I added a <chmod> to make that right in build/staging also.
N.B. this is issue 4718.i Please review this at http://gwt-code-reviews.appspot.com/89805 Affected files: distro-source/build.xml Index: distro-source/build.xml =================================================================== --- distro-source/build.xml (revision 6512) +++ distro-source/build.xml (working copy) @@ -31,7 +31,7 @@ <!-- raw files --> <zipfileset dir="${dist.resources}" prefix="${project.distname}" /> - <zipfileset dir="src" prefix="${project.distname}" /> + <zipfileset filemode="755" dir="src" prefix="${project.distname}" /> <!-- doc --> <zipfileset dir="${gwt.build.out}" prefix="${project.distname}"> @@ -58,5 +58,12 @@ --> <mkdir dir="${gwt.build.staging}" /> <unzip src="${project.dist}" dest="${gwt.build.staging}" /> + <!-- cute. zipinfo says the zip has good perms, unzip gets it right, but + ant <unzip> leaves the perms as non-executable... go figure. --> + <chmod perm="uga+rx"> + <fileset dir="${gwt.build.staging}/gwt-${gwt.version}"> + <patternset refid="chmod.executables"/> + </fileset> + </chmod> </target> </project> --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
