LGTM, some comments.
http://gwt-code-reviews.appspot.com/91809/diff/1/2 File user/super/com/google/gwt/emul/java/util/ArrayList.java (right): http://gwt-code-reviews.appspot.com/91809/diff/1/2#newcode79 Line 79: clearImpl(); While you're there, it seems like we should delete this block and simply initialize "array" inline. Can you think of any reason not to? The reasoning that went into "reusing" the implementation method is totally bogus in the face of modern compiler opts that will inline it. http://gwt-code-reviews.appspot.com/91809/diff/1/2#newcode85 Line 85: // Note - we avoid calling overridable methods from constructors Can you move this inside the bodies of the relevant constructors? http://gwt-code-reviews.appspot.com/91809/diff/1/2#newcode88 Line 88: if (!c.isEmpty()) { Do we actually need the guard? http://gwt-code-reviews.appspot.com/91809 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
