Okay, how's this? (gwt-code-reviews.appspot.com is suddenly puking when I try to upload patches to it, so here's one the old fashioned way. ) On Tue, Nov 3, 2009 at 4:06 PM, Amit Manjhi <amitman...@google.com> wrote:
> I agree with John. A system property is a global VM-wide option that seems > like an overkill for this purpose. A command line option with sane defaults > is probably the way to go. > > On Tue, Nov 3, 2009 at 3:50 PM, <j...@google.com> wrote: > >> On 2009/11/03 23:49:14, Ray Ryan wrote: >> >>> I imagine I'm not the only one who tweaks >>> >> JUnitShell.TEST_METHOD_TIMEOUT_MILLIS >> >>> when in the middle of long debug sessions. Wouldn't it be nice to be >>> >> able to do >> >>> so without touching the code? >>> >> >> General questions: is a system property the right way to do this; is >>> >> the >> >>> property name okay; and is it okay to hit the system properties at >>> >> class init >> >>> time like that? >>> >> >> Also deletes unneeded @SuppressWarnings >>> >> >> I think this would be better as a JUnitShell command line option. >> >> >> http://gwt-code-reviews.appspot.com/89819 >> > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
testMethodTimeout.diff
Description: Binary data
