LGTM On Wed, Nov 4, 2009 at 12:22 PM, <[email protected]> wrote:
> Reviewers: Ray Ryan, bruce, Dan Rice, > > Description: > SwingWorker uses a pool of threads to run background tasks, and we > weren't actually using the background portion of this. Having multiple > threads processing SwingWorker calls made ordering a problem (which > resulted in some nodes being added to the model before their parents > were), so I just switched to EventQueue.invokeLater which ensures proper > ordering. > > The tree node creation was simplified to make it easier to understand > what is going on, and a test app is included. > > Please review this at http://gwt-code-reviews.appspot.com/93802 > > Affected files: > dev/core/src/com/google/gwt/dev/shell/log/SwingTreeLogger.java > dev/core/test/com/google/gwt/dev/SwingTreeLoggerTestApp.java > dev/core/test/com/google/gwt/dev/util/log/AbstractTreeLoggerTest.java > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
