Reviewers: fabbott, Description: Description: ============= RPC tests often timeout because of slow server responses while the server is busy compiling other GWT modules.
Fix: === I added an RpcTestBase class that has a static RPC_TIMEOUT value. We can increase or decrease it if needed. I used 15 seconds because some tests transfer large amounts of data and were using 12 second delays. There are a few tests that transfer BMPs, and they have much higher timeouts. Also, I decided to create the RpcTestBase class instead of just putting RPC_TIMEOUT in RpcSuite because RpcSuite isn't on the source path for a GWT compile. RpcTestBase#delayTestFinishForRpc() is named that way so it shows up in the Eclipse auto complete when users type delayTestFinish. I also moved the delayTestFinishForRpc() directly above the RPC call. Currently, some tests create the service between delayTestFinish and the RPC call, which introduces a GWT.create() into the mix. Testing: ========= All tests passed. Please review this at http://gwt-code-reviews.appspot.com/93803 Affected files: user/test/com/google/gwt/user/client/rpc/CollectionsTest.java user/test/com/google/gwt/user/client/rpc/CustomFieldSerializerTest.java user/test/com/google/gwt/user/client/rpc/EnumsTest.java user/test/com/google/gwt/user/client/rpc/InheritanceTest.java user/test/com/google/gwt/user/client/rpc/ObjectGraphTest.java user/test/com/google/gwt/user/client/rpc/RemoteServiceServletTest.java user/test/com/google/gwt/user/client/rpc/RpcTestBase.java user/test/com/google/gwt/user/client/rpc/RunTimeSerializationErrorsTest.java user/test/com/google/gwt/user/client/rpc/ValueTypesTest.java --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
