Committed to /trunk @r6770. Committed to /releases/2.0 @r6771.
http://gwt-code-reviews.appspot.com/97805/diff/1/4 File samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.ui.xml (right): http://gwt-code-reviews.appspot.com/97805/diff/1/4#newcode13 Line 13: <g:DockPanel> On 2009/11/09 17:58:49, Ray Ryan wrote: > Why not DockLayoutPanel? Your sample is generating deprecation warnings... There was no particular reason to be using a panel at all. I just changed the whole thing to use HTML. Much simpler. http://gwt-code-reviews.appspot.com/97805/diff/1/5 File samples/mail/src/com/google/gwt/sample/mail/client/ContactPopup.ui.xml (right): http://gwt-code-reviews.appspot.com/97805/diff/1/5#newcode31 Line 31: <ui:image field='photo' src='default_photo.jpg'/> On 2009/11/09 17:58:49, Ray Ryan wrote: > Nit: move this above <ui:style> to be a little less confusing? Done. http://gwt-code-reviews.appspot.com/97805/diff/1/6 File samples/mail/src/com/google/gwt/sample/mail/client/MailList.java (right): http://gwt-code-reviews.appspot.com/97805/diff/1/6#newcode49 Line 49: static class NavBar extends Composite { On 2009/11/09 17:58:49, Ray Ryan wrote: > Why isn't this NavBar.java? Because I was being lazy. Converted to top-level. http://gwt-code-reviews.appspot.com/97805/diff/1/7 File samples/mail/src/com/google/gwt/sample/mail/client/MailList.ui.xml (right): http://gwt-code-reviews.appspot.com/97805/diff/1/7#newcode8 Line 8: border-left: 1px solid #999; On 2009/11/09 17:58:49, Ray Ryan wrote: > Nit: should just indent two more spaces inside rules. Actually, a lot of tabs snuck in here somehow. Fixed. http://gwt-code-reviews.appspot.com/97805/diff/1/7#newcode41 Line 41: <ui:style field='selectionStyle' type='com.google.gwt.sample.mail.client.MailList.SelectionStyle'> On 2009/11/09 17:58:49, Ray Ryan wrote: > Nit: to avoid this kind of wrapping I'm in the habit of indenting four more > spaces: > <ui:style field='...' > type='...'> > .selectedRow {... Done. http://gwt-code-reviews.appspot.com/97805/diff/1/8 File samples/mail/src/com/google/gwt/sample/mail/client/NavBar.ui.xml (right): http://gwt-code-reviews.appspot.com/97805/diff/1/8#newcode13 Line 13: <g:Anchor styleName='{style.anchor}' ui:field='newerButton' href='javascript:;'>< newer</g:Anchor> On 2009/11/09 17:58:49, Ray Ryan wrote: > Nit: could wrap at href (indent four more spaces) Done. http://gwt-code-reviews.appspot.com/97805/diff/1/9 File samples/mail/src/com/google/gwt/sample/mail/client/Shortcuts.ui.xml (right): http://gwt-code-reviews.appspot.com/97805/diff/1/9#newcode14 Line 14: gwt-image: 'gradient'; On 2009/11/09 17:58:49, Ray Ryan wrote: > Nit: inconsistent indentation here and below Damned tabs again. Fixed. http://gwt-code-reviews.appspot.com/97805/diff/1/10 File samples/mail/src/com/google/gwt/sample/mail/client/TopPanel.ui.xml (right): http://gwt-code-reviews.appspot.com/97805/diff/1/10#newcode25 Line 25: <ui:image field='logo' src='logo.png'/> On 2009/11/09 17:58:49, Ray Ryan wrote: > Nit: another spot where it would be better to declare the image first. Done. http://gwt-code-reviews.appspot.com/97805 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
