Reviewers: bobv, Message: Nits addressed, committed tr...@6774, 2.0 soon.
Description: DialogBox is weird--it implements both HasHTML and HasWidgets. This confuses the bejeebers out of UiBinder and leads it to generate bad code, so a custom parser is required. I took this excuse to generalize the mock UiBinderWriter work I did yesterday for DockLayoutPanelParserTest. I also found some low hanging fruit in XMLElement to allow it to fail when there are stray bits of text or widgets in places they shouldn't be. Previously this would result in quietly dropped text, or in things like <gwt:Label> showing up the rendered DOM, sometimes even user visible. Please review this at http://gwt-code-reviews.appspot.com/97806 Affected files: M user/src/com/google/gwt/uibinder/elementparsers/CustomButtonParser.java A user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java M user/src/com/google/gwt/uibinder/elementparsers/HtmlInterpreter.java M user/src/com/google/gwt/uibinder/rebind/FieldWriterOfExistingType.java M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java M user/src/com/google/gwt/uibinder/rebind/XMLElement.java M user/test/com/google/gwt/uibinder/UiBinderJreSuite.java A user/test/com/google/gwt/uibinder/elementparsers/DialogBoxParserTest.java M user/test/com/google/gwt/uibinder/elementparsers/DockLayoutPanelParserTest.java A user/test/com/google/gwt/uibinder/elementparsers/ElementParserTester.java A user/test/com/google/gwt/uibinder/elementparsers/MockUiBinderWriter.java A user/test/com/google/gwt/uibinder/elementparsers/UiJavaResources.java A user/test/com/google/gwt/uibinder/rebind/MockMortalLogger.java M user/test/com/google/gwt/uibinder/rebind/XMLElementTest.java M user/test/com/google/gwt/uibinder/test/UiJavaResources.java M user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
