On 2009/11/10 06:05:22, Ray Ryan wrote: > Hey, Joel. > As discussed, StackLayoutPanel now does the right thing WRT g:header and > g:customHeader. (The grotesque amount of copy/paste between > StackLayoutPanelParser, TabLayoutPanelParser and DisclosurePanel seems like a > massive clue that these three widgets--not the poor normalizing parsers--should > be sharing some code.)
> Also punched up parser strictness some more. Looks good to me. As for the overlap between Stack/TabLayoutPanel, I'm thinking of adding SLP.add(Widget, String, [boolean]), just like in TabLayoutPanel. We could hoist this into a common interface (HasDecoratedWidgets or something like that), which could simplify these parsers a lot. http://gwt-code-reviews.appspot.com/99801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
