Thanks for the heads-up, Yegor. Issue 3455 was specifically about the number of expressions in a single statement breaking JsCore, and shouldn't be tripped by a large string.
On Tue, Nov 10, 2009 at 2:42 PM, Yegor <yegor.jba...@gmail.com> wrote: > > Watch out. There used to be an issue with WebKit not being able to > handle long JS lines produced by GWT compiler with obfuscation: > > http://code.google.com/p/google-web-toolkit/issues/detail?id=3455 > > Yegor > > On Nov 10, 11:25 am, codesite-nore...@google.com wrote: > > Revision: 6798 > > Author: j...@google.com > > Date: Tue Nov 10 10:16:22 2009 > > Log: Fixes unnecessary newlines in obfuscated, generated CSS. > > Review by: bobv (desk check). > http://code.google.com/p/google-web-toolkit/source/detail?r=6798 > > > > Modified: > > /trunk/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java > > > > ======================================= > > --- > /trunk/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java > > Wed May 20 16:14:31 2009 > > +++ > /trunk/user/src/com/google/gwt/resources/css/CssGenerationVisitor.java > > Tue Nov 10 10:16:22 2009 > > @@ -85,7 +85,7 @@ > > public void endVisit(CssMediaRule x, Context ctx) { > > out.indentOut(); > > out.print("}"); > > - out.newline(); > > + out.newlineOpt(); > > } > > > > @Override > > @@ -98,7 +98,7 @@ > > public void endVisit(CssPageRule x, Context ctx) { > > out.indentOut(); > > out.print("}"); > > - out.newline(); > > + out.newlineOpt(); > > } > > > > @Override > > @@ -274,7 +274,7 @@ > > private void closeBrace() { > > out.indentOut(); > > out.print('}'); > > - out.newline(); > > + out.newlineOpt(); > > } > > > > private void colon() { > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
