http://gwt-code-reviews.appspot.com/102803/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java (right):
http://gwt-code-reviews.appspot.com/102803/diff/1/3#newcode134 Line 134: try { On 2009/11/12 02:27:11, mmendez wrote: > I'm fine to move it, but is there a reason that the location matters? It would > be good to add an explanation. > On 2009/11/11 21:49:53, rdayal wrote: > > Do this before telling the Dev Mode server that its okay to shut down. If you don't close the socket first, it is possible that the devmode server may shut down before this thread has a chance to close the socket. If it is is the case that the JVM closes all sockets on shutdown, then we're okay. Equivalently, if this thread is a non-daemon thread, then the JVM should wait till it terminates before shutting down the VM, in which case we should also be okay. However, if you move the close call after calling setDone, then all of these assumptions do not matter. http://gwt-code-reviews.appspot.com/102803 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
