Sigh, thanks for catching that.

Any suggestions for setting more than one icon in JDK 1.5?  If not, I
guess I can reflectively call setIconImages if it is there and
fallback to the old behavior on JDK 1.5.

On 11/18/09, Daniel Rice (דניאל רייס) <r...@google.com> wrote:
>   Window.setIconImages was introduced in Java 1.6.  This doesn't compile on
> 1.5.
>
> Dan
>
> On Tue, Nov 17, 2009 at 5:52 PM,  <codesite-nore...@google.com> wrote:
>> Revision: 6973
>> Author: j...@google.com
>> Date: Tue Nov 17 14:51:47 2009
>> Log: Adds additional icon sizes so Alt-Tab (etc) doesn't try and scale up
>> the 16x16
>> icon.  Also fixes unused import left in previous change.
>>
>> Patch by: jat
>> Review by: rjrjr (TBR)
>>
>> http://code.google.com/p/google-web-toolkit/source/detail?r=6973
>>
>> Added:
>>  /trunk/dev/core/src/com/google/gwt/dev/shell/icon64.png
>> Modified:
>>  /trunk/dev/core/src/com/google/gwt/dev/SwingUI.java
>>  /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
>>
>> =======================================
>> --- /dev/null
>> +++ /trunk/dev/core/src/com/google/gwt/dev/shell/icon64.png     Tue Nov 17
>> 14:51:47 2009
>> Binary file, no diff available.
>> =======================================
>> --- /trunk/dev/core/src/com/google/gwt/dev/SwingUI.java Fri Oct 16
>> 20:22:17
>> 2009
>> +++ /trunk/dev/core/src/com/google/gwt/dev/SwingUI.java Tue Nov 17
>> 14:51:47
>> 2009
>> @@ -31,6 +31,7 @@
>>  import java.awt.event.WindowEvent;
>>  import java.io.File;
>>  import java.net.URL;
>> +import java.util.Arrays;
>>  import java.util.Map;
>>
>>  import javax.swing.Icon;
>> @@ -181,7 +182,12 @@
>>   �...@override
>>    public void initialize(Type logLevel) {
>>      super.initialize(logLevel);
>> -    ImageIcon gwtIcon = loadImageIcon("icon24.png");
>> +    ImageIcon gwtIcon16 = loadImageIcon("icon16.png");
>> +    ImageIcon gwtIcon24 = loadImageIcon("icon24.png");
>> +    ImageIcon gwtIcon32 = loadImageIcon("icon32.png");
>> +    ImageIcon gwtIcon48 = loadImageIcon("icon48.png");
>> +    ImageIcon gwtIcon64 = loadImageIcon("icon64.png");
>> +    ImageIcon gwtIcon128 = loadImageIcon("icon128.png");
>>      frame = new JFrame("GWT Development Mode");
>>      tabs = new JTabbedPane();
>>      if (options.alsoLogToFile()) {
>> @@ -189,7 +195,7 @@
>>      }
>>      mainWnd = new ShellMainWindow(logLevel,
>> options.getLogFile("main.log"));
>>      topLogger = mainWnd.getLogger();
>> -    tabs.addTab("Development Mode", gwtIcon, mainWnd, "GWT Development
>> Mode");
>> +    tabs.addTab("Development Mode", gwtIcon24, mainWnd, "GWT Development
>> Mode");
>>      frame.getContentPane().add(tabs);
>>      frame.setSize(950, 700);
>>      frame.setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
>> @@ -202,7 +208,9 @@
>>          }
>>        }
>>      });
>> -    frame.setIconImage(loadImageIcon("icon16.png").getImage());
>> +    frame.setIconImages(Arrays.asList(gwtIcon48.getImage(),
>> +        gwtIcon32.getImage(), gwtIcon64.getImage(),
>> gwtIcon128.getImage(),
>> +        gwtIcon16.getImage()));
>>      frame.setVisible(true);
>>    }
>>
>> =======================================
>> --- /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
>> Tue Nov 17 14:20:58 2009
>> +++ /trunk/dev/core/src/com/google/gwt/dev/shell/log/SwingLoggerPanel.java
>> Tue Nov 17 14:51:47 2009
>> @@ -68,7 +68,6 @@
>>  import javax.swing.event.TreeSelectionListener;
>>  import javax.swing.event.HyperlinkEvent.EventType;
>>  import javax.swing.text.html.HTMLDocument;
>> -import javax.swing.text.html.HTMLEditorKit;
>>  import javax.swing.tree.DefaultMutableTreeNode;
>>  import javax.swing.tree.DefaultTreeCellRenderer;
>>  import javax.swing.tree.DefaultTreeModel;
>>
>> --
>> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>>
>


-- 
John A. Tamplin
Software Engineer (GWT), Google

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to