Lex, Next patch will contains 3 optimizations. Promise! :)
http://gwt-code-reviews.appspot.com/117805/diff/2047/1046 File dev/core/src/com/google/gwt/dev/util/Either.java (right): http://gwt-code-reviews.appspot.com/117805/diff/2047/1046#newcode76 Line 76: return true; On 2009/12/15 23:00:37, Lex wrote: > I believe this would be shorter if it tested for the true cases rather than the > false ones. There are only two true cases: lefty and the lefts match, righty > and the rights match. Oh, this is just auto-generated code. Fixed it. http://gwt-code-reviews.appspot.com/117805/diff/2047/1047 File dev/core/src/com/google/gwt/dev/util/Preconditions.java (right): http://gwt-code-reviews.appspot.com/117805/diff/2047/1047#newcode48 Line 48: * This class was adapted from google-collections project. On 2009/12/15 23:00:37, Lex wrote: > Missing <p> ? Done. http://gwt-code-reviews.appspot.com/117805/diff/2047/1050 File dev/core/test/com/google/gwt/dev/jjs/impl/gflow/cfg/CfgBuilderTest.java (right): http://gwt-code-reviews.appspot.com/117805/diff/2047/1050#newcode18 Line 18: public class CfgBuilderTest extends OptimizerTestBase { On 2009/12/15 23:00:37, Lex wrote: > This test and CfgPrint are great! > FWIW, I found the "*" notation for "next node" to take me a while to figure out. > I'm not sure what to suggest that would be any better, though. IT does have > the benefit of being concise. It's not only concise. It's more stable. Originally I labeled every node of the graph, but if you change your cfg to have additional node, all nodes are shifted. This is much more stable. Ideally it should look like BASIC (* is assumed by default), but I'd like to keep everything explicit. http://gwt-code-reviews.appspot.com/117805/diff/2047/1050#newcode645 Line 645: " if (b) throw uncheckedException1;", On 2009/12/15 23:00:37, Lex wrote: > A tricky case that I don't see covered is throwUncheckedException(). That is, > any method call can result in an unchecked exception being thrown. Done. http://gwt-code-reviews.appspot.com/117805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
