LGTM w/ nits.

http://gwt-code-reviews.appspot.com/132815/diff/3001/3003
File dev/core/src/com/google/gwt/dev/js/JsStackEmulator.java (right):

http://gwt-code-reviews.appspot.com/132815/diff/3001/3003#newcode594
Line 594: private final Set<JsNode<?>> invokedNodes = new
HashSet<JsNode<?>>();
Add javadoc

http://gwt-code-reviews.appspot.com/132815/diff/3001/3003#newcode759
Line 759: private final JsName rootLineNumbers =
program.getRootScope().findExistingUnobfuscatableName(
Why is this moved?

http://gwt-code-reviews.appspot.com/132815/diff/3001/3005
File
user/test/com/google/gwt/core/client/impl/StackTraceLineNumbersTest.java
(right):

http://gwt-code-reviews.appspot.com/132815/diff/3001/3005#newcode24
Line 24: public class StackTraceLineNumbersTest extends GWTTestCase {
Doesn't this needed to be added to CompilerSuite?

http://gwt-code-reviews.appspot.com/132815

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to