Looks great. I still have to look over the update to tools. Just a few
comments on the patch to gwt-trunk:
- Does the CL pass 100% even in repeated runs of dev, prod, emma, and
other relevant modes?
- CreateEventTest.java: sorting of imports seems incorrect.
- For every test where you add a @DoNotRunWith(...), can you please add
which mode (dev, prod, emma, ...) it fails in?
- Can you change the comment "Failed intermittently due to synchronized
test with HtmlUnit." to "Failed intermittently due to threading issues
with HtmlUnit."?


http://gwt-code-reviews.appspot.com/134806

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to