Sounds exciting. Looking forward to your patches. On Sun, Feb 7, 2010 at 11:53 PM, Tomer Greenberg <tomer...@google.com>wrote:
> I'm working on a new class named AutoDirHandler, which is supposed to > listen on keypress events and adjust the directionality of the TA / TB as > you type. The AutoDirHandler is a private member of the TA / TB, which also > supply methods to enable / disable it. > > > On Thu, Feb 4, 2010 at 8:12 PM, Ray Ryan <rj...@google.com> wrote: > >> I more wanted to hear an elaboration on "I'm going to add some BiDi >> functionality to TextBox and TextArea." >> >> But given that Both of TA and TB implement the interface, refactoring the >> copy/paste implementation sounds good to me. >> >> On Wed, Feb 3, 2010 at 4:01 AM, tomerigo <tomer...@google.com> wrote: >> >>> I want TextBoxBase to implement HasDirection, which means moving the >>> implementation of setDirection and getDirection from TextBox / >>> TextArea to TextBoxBase. >>> >>> On 2 פברואר, 23:00, Ray Ryan <rj...@google.com> wrote: >>> > Extending TextBoxBase sounds perfectly reasonable, but what exactly are >>> you >>> > proposing to implement there? >>> > >>> > On Tue, Feb 2, 2010 at 10:58 AM, Tomer Greenberg <tomer...@google.com >>> >wrote: >>> > >>> > >>> > >>> > > Hello gwters, >>> > >>> > > I'm going to add some BiDi functionality to TextBox and TextArea. >>> Given >>> > > that their parent, TextBoxBase, doesn't implement HasDirection, this >>> has to >>> > > be done (in an identical manner) for TextBox and TextArea separately. >>> But >>> > > then, why won't TextBoxBase implement HasDirection instead of its >>> children? >>> > > This way we could save a lot of code duplication, and it's also >>> reasonable - >>> > > if it has text, it also has direction. >>> > >>> > > Any objections? >>> > >>> > > Thanks >>> > >>> > > Tomer >>> > >>> > > -- >>> > >http://groups.google.com/group/Google-Web-Toolkit-Contributors >>> > >>> > -- >>> > I wish this were a Wave >>> >>> -- >>> http://groups.google.com/group/Google-Web-Toolkit-Contributors >>> >> >> >> >> -- >> I wish this were a Wave >> >> -- >> http://groups.google.com/group/Google-Web-Toolkit-Contributors >> > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- I wish this were a Wave -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
