Oh, course, nevermind, LGTM On Thu, Feb 11, 2010 at 12:01 PM, Pete Hopkins <phopk...@google.com> wrote:
> On Thu, Feb 11, 2010 at 2:58 PM, <rj...@google.com> wrote: > > One more tweak, though: > > > > > > http://gwt-code-reviews.appspot.com/136805/diff/5001/5002 > > File user/src/com/google/gwt/event/shared/HandlerManager.java (right): > > > > http://gwt-code-reviews.appspot.com/136805/diff/5001/5002#newcode71 > > Line 71: causes.add(e); > > Seems like this and the identical call below should be refactored into a > > single method > > That's tricky to do because the causes variable needs to get > initialized from the common code. I don't think causes can be made a > member variable because that method needs to be reentrant. > > The alternative would be passing in causes and then returning it from > the helper method (so that the helper could initialize it), or doing > away with the optimization of only creating causes when it's needed. > > > -- Pete > -- I wish this were a Wave -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
