Bit petty but shouldn't Collections be final. Many (most) Collections inner classes can also be private rather than package private which should make life for the compiler that bit easier.

Hth

On 18/02/2010, at 6:14 AM, sco...@google.com wrote:


http://gwt-code-reviews.appspot.com/146801/diff/1/3
File user/super/com/google/gwt/emul/java/util/Collections.java (right):

http://gwt-code-reviews.appspot.com/146801/diff/1/3#newcode44
Line 44: private Object readResolve() {
We generally don't implement Java serialization semantics in our JRE,
but I suppose this is harmless enough.

http://gwt-code-reviews.appspot.com/146801/diff/1/3#newcode83
Line 83: private static final class EmptyMap extends AbstractMap
implements
Might as well implement size() to return 0?

http://gwt-code-reviews.appspot.com/146801

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to