Sorry for the patch spam.  v4 should be good to go!

http://gwt-code-reviews.appspot.com/181801/diff/1/2
File user/super/com/google/gwt/emul/java/util/Date.java (right):

http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode27
Line 27: static class JsDate extends JavaScriptObject {
Hehe, let's consider this in a follow-up.

http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode285
Line 285: return (int) (time ^ (getTime() >>> 32));
Whoops, good call.  I forgot I unchecked the 'replace all occurrences'
when pulling out locals.

http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode343
Line 343: String hourOffset = (offset >= 0) ? "+" : "" + (offset / 60);
On 2010/03/11 19:35:23, Dan Rice wrote:
Parens around the ?: expression would be nice

Done.

http://gwt-code-reviews.appspot.com/181801

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to