Revision: 7725
Author: rj...@google.com
Date: Fri Mar 12 14:33:11 2010
Log: Fix dates inefficiently for a moment, pending Date fix to get JSO
friendly again
http://gwt-code-reviews.appspot.com/195801
Review by: amitman...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=7725
Added:
/trunk/bikeshed/eclipse.README
Modified:
/trunk/bikeshed/src/com/google/gwt/sample/expenses/client/ValuesImpl.java
=======================================
--- /dev/null
+++ /trunk/bikeshed/eclipse.README Fri Mar 12 14:33:11 2010
@@ -0,0 +1,22 @@
+To make eclipse go:
+
+* Set svn or git or whatever to exclude the following:
+
+.settings
+.classpath
+.project
+bin
+build
+classes
+com.google.gwt.*
+eclipse-trunk
+bikeshed/war/expenses
+bikeshed/war/stocks
+bikeshed/war/tree
+
+* Install the Google Plugin for Eclipse
+* Import bikeshed as a new Java project with existing source
+* Bring up the project properties and find the Google settings, and turn
on AppEngine and WebKit
+* Copy tools/redist/json/r2_20080312/json.jar to bikeshed/war/WEB_INF/lib
+* Right click on the bikeshed project and choose Run as > Web Application.
Choose from the various .html files
+
=======================================
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/client/ValuesImpl.java
Fri Mar 12 09:35:24 2010
+++
/trunk/bikeshed/src/com/google/gwt/sample/expenses/client/ValuesImpl.java
Fri Mar 12 14:33:11 2010
@@ -15,7 +15,6 @@
*/
package com.google.gwt.sample.expenses.client;
-import com.google.gwt.core.client.GWT;
import com.google.gwt.core.client.JavaScriptObject;
import com.google.gwt.core.client.JsArray;
import com.google.gwt.valuestore.shared.Property;
@@ -49,12 +48,13 @@
}
if (Date.class.equals(property.getValueType())) {
double millis = getDouble(property.getName());
- if (GWT.isScript()) {
- return (V) initDate(new Date(), millis);
- } else {
+ //TODO (rjrjr) bring this back when Date gets JSO friendly again
+// if (GWT.isScript()) {
+// return (V) initDate(new Date(), millis);
+// } else {
// In dev mode, we're using real JRE dates
return (V) new Date((long) millis);
- }
+// }
}
return nativeGet(property);
@@ -80,10 +80,10 @@
return this[name];
}-*/;
- private native Date initDate(Date date, double millis) /*-{
- da...@java.util.date::init(D)(millis);
- return date;
- }-*/;
+// private native Date initDate(Date date, double millis) /*-{
+// da...@java.util.date::init(D)(millis);
+// return date;
+// }-*/;
private native <V, P extends Property<T, V>> V nativeGet(P property) /*-{
return
this[proper...@com.google.gwt.valuestore.shared.property::getName()()];
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
