Reviewers: jgw,

Description:
Don't ever set the "base" variable to null.  It is supposed to be the
empty string
if it hasn't been set yet.


Please review this at http://gwt-code-reviews.appspot.com/219801

Affected files:
  M dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
  M dev/core/src/com/google/gwt/core/linker/XSTemplate.js


Index: dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js
===================================================================
--- dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js (revision 7732)
+++ dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js   (working copy)
@@ -120,7 +120,8 @@
     ,markerId = "__gwt_marker___MODULE_NAME__"
     ,markerScript;

-    if (base = metaProps['baseUrl']) {
+    if (metaProps['baseUrl']) {
+      base = metaProps['baseUrl'];
       return;
     }

Index: dev/core/src/com/google/gwt/core/linker/XSTemplate.js
===================================================================
--- dev/core/src/com/google/gwt/core/linker/XSTemplate.js       (revision 7732)
+++ dev/core/src/com/google/gwt/core/linker/XSTemplate.js       (working copy)
@@ -104,7 +104,8 @@
     ,markerId = "__gwt_marker___MODULE_NAME__"
     ,markerScript;

-    if (base = metaProps['baseUrl']) {
+    if (metaProps['baseUrl']) {
+      base = metaProps['baseUrl'];
       return;
     }



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to