Additional checkstyle problems (Eclipse output). Please run checkstyle
:)
Description Resource Path Location Type
forProperties is not
alphabetical. EntityListRequest.java
Bikeshed/src/com/google/gwt/requestfactory/shared line
35 Checkstyle Problem
getDetailsPlaceFor is not
alphabetical. Places.java
Bikeshed/src/com/google/gwt/sample/expenses/client/place line
34 Checkstyle Problem
Line does not match expected header line of
'/\*'. ExpensesScaffold.java
Bikeshed/src/com/google/gwt/sample/expenses/client line
1 Checkstyle Problem
Line does not match expected header line of
'/\*'. ListRequester.java
Bikeshed/src/com/google/gwt/sample/expenses/client line
1 Checkstyle Problem
Line matches the illegal pattern 'newline before
}'. ListRequester.java Bikeshed/src/com/google/gwt/sample/expenses/client
line
45 Checkstyle Problem
http://gwt-code-reviews.appspot.com/209802/diff/1/16
File
bikeshed/src/com/google/gwt/sample/expenses/client/ExpensesScaffoldShell.java
(right):
http://gwt-code-reviews.appspot.com/209802/diff/1/16#newcode32
Line 32: interface Binder extends UiBinder<Widget,
ExpensesScaffoldShell> {}
checkstyle. "{" is not followed by whitespace.
http://gwt-code-reviews.appspot.com/209802/diff/1/24
File
bikeshed/src/com/google/gwt/sample/expenses/client/place/EntityPlace.java
(right):
http://gwt-code-reviews.appspot.com/209802/diff/1/24#newcode45
Line 45: if (this == obj)
checkstyle: not alphabetical
http://gwt-code-reviews.appspot.com/209802/diff/1/34
File
bikeshed/src/com/google/gwt/sample/expenses/server/domain/Storage.java
(right):
http://gwt-code-reviews.appspot.com/209802/diff/1/34#newcode145
Line 145: synchronized List<Report> findAllReports() {
checkstyle: findAllReports is not alphabetical
http://gwt-code-reviews.appspot.com/209802/diff/1/42
File bikeshed/src/com/google/gwt/user/client/ui/ValueListBox.java
(right):
http://gwt-code-reviews.appspot.com/209802/diff/1/42#newcode87
Line 87: public HandlerRegistration
addValueChangeHandler(ValueChangeHandler<T> handler) {
checkstyle: method is not alphabetical.
http://gwt-code-reviews.appspot.com/209802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
