Thanks, Scott. I added the TODO at the place indicated. It applies more broadly, though: any place the inliner looks at a function call, it would be nice to know what if any side effects that function call has and would be affected by.
http://gwt-code-reviews.appspot.com/344801/diff/1/2 File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right): http://gwt-code-reviews.appspot.com/344801/diff/1/2#newcode677 dev/core/src/com/google/gwt/dev/js/JsInliner.java:677: public void endVisit(JsNew x, JsContext<JsExpression> ctx) { Done and done. http://gwt-code-reviews.appspot.com/344801/diff/1/3 File dev/core/test/com/google/gwt/dev/js/JsInlinerTest.java (right): http://gwt-code-reviews.appspot.com/344801/diff/1/3#newcode120 dev/core/test/com/google/gwt/dev/js/JsInlinerTest.java:120: System.err.println("Input vs "); On 2010/04/13 15:07:30, scottb wrote:
Unrelated to your patch, but maybe yank this line while you're here?
Done. http://gwt-code-reviews.appspot.com/344801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
