[gwt-contrib] Ensure static initialization is atomic (found by findbugs) (issue341802)

[rice]

Reviewers: kathrin,

Description:
Ensure static initialization is atomic (found by findbugs)

Please review this at http://gwt-code-reviews.appspot.com/341802/show

Affected files:
  M user/src/com/google/gwt/user/client/Cookies.java


Index: user/src/com/google/gwt/user/client/Cookies.java
===================================================================
--- user/src/com/google/gwt/user/client/Cookies.java    (revision 7925)
+++ user/src/com/google/gwt/user/client/Cookies.java    (working copy)
@@ -228,8 +228,9 @@

   private static HashMap<String, String> ensureCookies() {
     if (cachedCookies == null || needsRefresh()) {
-      cachedCookies = new HashMap<String, String>();
-      loadCookies(cachedCookies);
+      HashMap<String, String> newCachedCookies = new HashMap<String,  
String>();
+      loadCookies(newCachedCookies);
+      cachedCookies = newCachedCookies;
     }
     return cachedCookies;
   }


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors