Mostly LGTM

A couple of nits, and one more significant.


http://gwt-code-reviews.appspot.com/397801/diff/1/3
File user/src/com/google/gwt/user/tools/README.txtsrc (right):

http://gwt-code-reviews.appspot.com/397801/diff/1/3#newcode75
user/src/com/google/gwt/user/tools/README.txtsrc:75: have Internet o
Local access to maven repositories, and the comand 'mvn' is in
s/o/or/ ?

http://gwt-code-reviews.appspot.com/397801/diff/1/6
File user/src/com/google/gwt/user/tools/WebAppCreator.java (right):

http://gwt-code-reviews.appspot.com/397801/diff/1/6#newcode241
user/src/com/google/gwt/user/tools/WebAppCreator.java:241: return "Do
not create ant configuration file";
"an ant"

http://gwt-code-reviews.appspot.com/397801/diff/1/6#newcode329
user/src/com/google/gwt/user/tools/WebAppCreator.java:329: String
warFolder = maven ? "src/main/webapp" : "war";
Will this do the right thing without -noant?  It seems like the ant file
would point at the maven directories, but maybe that works anyway.

If not, then perhaps -maven should mean to generate maven files rather
than ant files (doing away with -noant).

http://gwt-code-reviews.appspot.com/397801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to