[gwt-contrib] Updating Mobile expenses app now that prices are stored in dollars instead of cents. (issue514801)

Wed, 12 May 2010 09:49:07 -0700 

Reviewers: jgw,

Description:
Updating Mobile expenses app now that prices are stored in dollars
instead of cents.


Please review this at http://gwt-code-reviews.appspot.com/514801/show

Affected files:
M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java M /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java
Index: /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java 
===================================================================
--- /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java (revision 8094) +++ /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java (working copy) 
@@ -28,10 +28,13 @@

   /**
    * TODO(jgw): Put this some place more sensible.
+   *
+   * @param amount the amount in dollars
    */
-  public static String formatCurrency(int price) {
+  public static String formatCurrency(double amount) {
     StringBuilder sb = new StringBuilder();

+    int price = (int) (amount * 100);
     boolean negative = price < 0;
     if (negative) {
       price = -price;
Index: /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java 
===================================================================
--- /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java (revision 8094) +++ /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseDetails.java (working copy) 
@@ -119,6 +119,6 @@
     nameText.setInnerText(expense.getDescription());
     dateText.setInnerText(formatter.format(expense.getCreated()));
     categoryText.setInnerText(expense.getCategory());
- priceText.setInnerText(ExpensesMobile.formatCurrency(expense.getAmount().intValue())); + priceText.setInnerText(ExpensesMobile.formatCurrency(expense.getAmount())); 
   }
 }
Index: /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java 
===================================================================
--- /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java (revision 8094) +++ /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseEntry.java (working copy) 
@@ -105,7 +105,7 @@
     // TODO(jgw): validate amount (in dollars -- database is in pennies)
     String amountText = priceText.getText();
     double amount = Double.parseDouble(amountText);
-    deltas.set(ExpenseRecord.amount, expense, amount * 100);
+    deltas.set(ExpenseRecord.amount, expense, amount);

     // TODO(jgw): Use non-deprecated date methods for this.
     Date date = new Date(
@@ -145,7 +145,7 @@
   private void displayExpense() {
     nameText.setText(expense.getDescription());
     categoryText.setText(expense.getCategory());
- priceText.setText(ExpensesMobile.formatCurrency(expense.getAmount().intValue())); 
+    priceText.setText(ExpensesMobile.formatCurrency(expense.getAmount()));

     // TODO(jgw): Use non-deprecated date methods for this.
     Date d = expense.getCreated();
Index: /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java 
===================================================================
--- /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java (revision 8094) +++ /bikeshed/src/com/google/gwt/sample/expenses/gwt/client/MobileExpenseList.java (working copy) 
@@ -44,6 +44,7 @@
    */
   public interface Listener {
     void onExpenseSelected(ExpenseRecord expense);
+
     void onCreateExpense(String reportId);
   }

@@ -65,8 +66,8 @@
           @Override
           public void render(ExpenseRecord value, Object viewData,
               StringBuilder sb) {
- sb.append("<div onclick='' class='item'>" + value.getDescription() + " ($" + 
-                ExpensesMobile.formatCurrency(value.getAmount().intValue())
+ sb.append("<div onclick='' class='item'>" + value.getDescription() 
+                + " ($" + ExpensesMobile.formatCurrency(value.getAmount())
                 + ")</div>");
           }
         });


--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to