LGTM

http://gwt-code-reviews.appspot.com/545801/diff/1/3
File dev/core/test/com/google/gwt/core/linker/SoycReportLinkerTest.java
(right):

http://gwt-code-reviews.appspot.com/545801/diff/1/3#newcode80
dev/core/test/com/google/gwt/core/linker/SoycReportLinkerTest.java:80: }
This test is good, but it wouldn't have caught the bug that alerted us
to a problem: we had an index.html file but it didn't contain anything
beyond the header.  Do you think it's worthwhile actually looking inside
the produced file? Maybe you could do this in SoycTest, where we already
look for actual files produced by Hello.

http://gwt-code-reviews.appspot.com/545801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to