Can you make sure that contrib is cc'd in the issue settings?


http://gwt-code-reviews.appspot.com/612802/diff/1/2
File user/src/com/google/gwt/user/client/ui/Panel.java (right):

http://gwt-code-reviews.appspot.com/612802/diff/1/2#newcode231
user/src/com/google/gwt/user/client/ui/Panel.java:231: private static
native void eraseDom(Element element) /*-{
There is really no need for this method, and also no need for it to be
native. Why not just call this.getElement().setInnerHTML("") at the only
call site?

http://gwt-code-reviews.appspot.com/612802/diff/1/3
File user/test/com/google/gwt/user/client/ui/RootPanelTest.java (right):

http://gwt-code-reviews.appspot.com/612802/diff/1/3#newcode33
user/test/com/google/gwt/user/client/ui/RootPanelTest.java:33: public
void testClear() {
These two new tests should be in PanelTestBase. Can you also try making
this test extend that one? It's odd that it doesn't. I imagine there's a
good reason but it might be an oversight. If it doesn't work, could you
explain so and why in the RootPanelTest class doc? If there are one or
two problem tests, they could be overridden to be no-ops.

http://gwt-code-reviews.appspot.com/612802/diff/1/3#newcode51
user/test/com/google/gwt/user/client/ui/RootPanelTest.java:51: public
void testClearWithDomErasure() {
I'm very surprised that this doesn't destroy all downstream tests. Have
you run the full suite?

http://gwt-code-reviews.appspot.com/612802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to