Thanks, Alex! Just nits: - Let's attribute the original author(s) in the change description
- Let's put the edit-distance classes in a subpackage of com.google.gwt.dev.util. Perhaps simply com.google.gwt.dev.util.editdistance ? http://gwt-code-reviews.appspot.com/669801/diff/1/7 File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java (right): http://gwt-code-reviews.appspot.com/669801/diff/1/7#newcode41 dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:41: private static final int GOOD_ENOUGH_DISTANCE = 5; Please add comments for these new variables. Adding one for MAX_DISTANCE_LIMIT wouldn't be bad, either, if you get on a roll. http://gwt-code-reviews.appspot.com/669801/diff/1/7#newcode98 dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:98: while (it.hasNext() && bestDistance > GOOD_ENOUGH_DISTANCE && I presume you tested that the GOOD_ENOUGH_DISTANCE heuristic is worth it? That is, the output is surely a little worse, but you must have verified that we get a lot of speedup in return? http://gwt-code-reviews.appspot.com/669801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
