LGTM On Mon, Jul 12, 2010 at 4:58 PM, Scott Blum <sco...@google.com> wrote:
> On Mon, Jul 12, 2010 at 4:54 PM, <fabb...@google.com> wrote: > >> http://gwt-code-reviews.appspot.com/685801/diff/1/2#newcode594 >> dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:594: >> return result; >> Cool, but is this better than stabilizing allTypes.values itself? >> > > Yes... I thought about making allTypes a TreeSet, but the thing is, > TypeOracle.allTypes() has almost no callers. It's just test code, and > symbol dumping. Whereas, making it a TreeSet would have a performance > impact every time you build a TypeOracle, which is the 99% case. > > >> >> http://gwt-code-reviews.appspot.com/685801/diff/1/3 >> File dev/core/src/com/google/gwt/dev/Precompile.java (left): >> >> http://gwt-code-reviews.appspot.com/685801/diff/1/3#oldcode479 >> dev/core/src/com/google/gwt/dev/Precompile.java:479: } >> but shouldn't we dump sometimes? Or is this block full-up buggy, and >> the real dump is elsewhere? > > > See my in-flight note. > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
