Updated based on the conversation with rjrjr and the new design doc. Instead of passing viewData and a ViewDataUpdater into cells, we create AbstractEditableCell that provides an API to store view data. That means that Cell does not have a concept of ViewData, and the ViewData in AbstractEditableCell is typed.
ViewDataManager is gone, and widgets no longer need to provide any specific support for ViewData. Cell methods now take the Object key as a parameter. http://gwt-code-reviews.appspot.com/689801/diff/1001/2001 File bikeshed/src/com/google/gwt/sample/bikeshed/cookbook/client/CellSamplerRecipe.java (right): http://gwt-code-reviews.appspot.com/689801/diff/1001/2001#newcode105 bikeshed/src/com/google/gwt/sample/bikeshed/cookbook/client/CellSamplerRecipe.java:105: this.status = "Active"; On 2010/07/14 13:47:38, Ray Ryan wrote:
Why not use the constant you defined above? For that matter, why not
use a
status enum and get these display strings from a method on it?
Done. http://gwt-code-reviews.appspot.com/689801/diff/1001/2008 File user/src/com/google/gwt/cell/client/Cell.java (right): http://gwt-code-reviews.appspot.com/689801/diff/1001/2008#newcode71 user/src/com/google/gwt/cell/client/Cell.java:71: * @param valueUpdater a {...@link ValueUpdater}, or null valueUpdater can be null if the user doesn't specify one. For CellList, the user must specify a ValueUpdater. For CellTable, the user must specify a FieldUpdater in the column. For readonly cells (such as TextCell), it will most likely be null. http://gwt-code-reviews.appspot.com/689801/diff/1001/2017 File user/src/com/google/gwt/cell/client/ViewDataManager.java (right): http://gwt-code-reviews.appspot.com/689801/diff/1001/2017#newcode25 user/src/com/google/gwt/cell/client/ViewDataManager.java:25: * Handles view data objects. Updated the JavaDoc. This is for authors of widgets, and its used by CellList, CellTable, and CellTreeNodeView. Its unlikely that anyone would need to edit it. http://gwt-code-reviews.appspot.com/689801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
