LGTM, just one question.

http://gwt-code-reviews.appspot.com/697802/diff/5001/6001
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):

http://gwt-code-reviews.appspot.com/697802/diff/5001/6001#newcode90
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:90:
writer.addStatement("%s.resize(%s, %s);", fieldName,
Would it be better to only call resizeRows or resizeColumns if one of
rows/cols are 0?

http://gwt-code-reviews.appspot.com/697802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to