Thanks for the patch!

We just noticed this ourselves, and a broader patch should soon go in that
includes this fix.

On Thu, Jul 22, 2010 at 7:59 AM, <i...@invalidip.com> wrote:

> Reviewers: ,
>
> Description:
> When more than one RequestFactory is created, we are getting compiling
> errors because some of the records are not in the same package than the
> actual request factory. To fix this, we simply add all the imports to
> the RequestFactoryGenerator in order to know where to find these
> records.
>
> Please review this at http://gwt-code-reviews.appspot.com/653802/show
>
> Affected files:
>  user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
>
>
> Index:
> user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
> ===================================================================
> ---
> user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
>  (revision 8401)
> +++
> user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
>  (working copy)
> @@ -315,6 +315,12 @@
>     f.addImport(interfaceType.getQualifiedSourceName());
>     f.addImport(Record.class.getName());
>     f.addImport(RecordSchema.class.getName());
> +
> +    for (JClassType publicRecordType : generatedRecordTypes) {
> +        f.addImport(publicRecordType.getPackage().getName() + "." +
> publicRecordType.getName());
> +        f.addImport(publicRecordType.getPackage().getName() + "." +
> publicRecordType.getName() + "Impl");
> +    }
> +
>     f.addImplementedInterface(interfaceType.getName());
>
>     f.addImplementedInterface(interfaceType.getName());
>
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
>

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to