Ready for re-review
http://gwt-code-reviews.appspot.com/710801/diff/4001/5001 File bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java (left): http://gwt-code-reviews.appspot.com/710801/diff/4001/5001#oldcode50 bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java:50: // } I'm taking this as an opportunity to clean up RF a bit. This is a very stale comment. http://gwt-code-reviews.appspot.com/710801/diff/4001/5004 File eclipse/samples/DynaTableRf/DynaTableRf.launch (right): http://gwt-code-reviews.appspot.com/710801/diff/4001/5004#newcode16 eclipse/samples/DynaTableRf/DynaTableRf.launch:16: <stringAttribute key="org.eclipse.jdt.launching.VM_ARGUMENTS" value="-ea -Xmx256M -Dgwt.devjar=${gwt_devjar}"/> Fixed here and in DT http://gwt-code-reviews.appspot.com/710801/diff/4001/5008 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml (right): http://gwt-code-reviews.appspot.com/710801/diff/4001/5008#newcode20 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/DynaTableRf.gwt.xml:20: <inherits name='com.google.gwt.rpc.RPC' /> On 2010/07/23 17:53:38, amitmanjhi wrote:
Why does DynaTableRf still need RPC?
Done. http://gwt-code-reviews.appspot.com/710801/diff/4001/5009 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java (right): http://gwt-code-reviews.appspot.com/710801/diff/4001/5009#newcode30 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java:30: // private final SchoolCalendarServiceAsync calService; On 2010/07/23 18:12:40, bobv wrote:
Remove comment.
Done. http://gwt-code-reviews.appspot.com/710801/diff/4001/5009#newcode47 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java:47: // (Which is a totally demo hack, by the way :-) On 2010/07/23 18:12:40, bobv wrote:
No longer relevant.
Done. http://gwt-code-reviews.appspot.com/710801/diff/4001/5009#newcode87 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java:87: // rows[i][2] = person.getSchedule(daysFilter); Made it a TODO http://gwt-code-reviews.appspot.com/710801/diff/4001/5015 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java (right): http://gwt-code-reviews.appspot.com/710801/diff/4001/5015#newcode24 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java:24: public abstract class Person implements IsSerializable { On 2010/07/23 18:12:40, bobv wrote:
Remove IsSerializable?
Done, across the board. Expunged serial and RPC refs from comments as well, and added a few todos related to as-yet unimplemented error handling. http://gwt-code-reviews.appspot.com/710801/diff/4001/5027 File user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/710801/diff/4001/5027#newcode273 user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:273: String simpleSourceName = requestSelector.getSimpleSourceName(); It is now, I think. Also fixed a bit of silliness where the method name had to match the return type. And Unnur's about to fix a few other similar problems. We also shouldn't require that selectors exist -- there's no reason you shouldn't be able to define a getRequest() type method right on the factory. But I don't want to mess with that right now. On 2010/07/23 18:12:40, bobv wrote:
Is is possible to have classes from different packages in the list of requestSelectors?
http://gwt-code-reviews.appspot.com/710801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
