[gwt-contrib] Re: No longer require RPCs to contain a 'Content-Length' HTTP request header, thus (issue727801)

[conroy]

On 2010/07/29 06:59:33, fredsa wrote:


I believe that RequestFactoryServlet also suffers from the same bug:

RequestFactoryServlet.java:305
  private String getContent(HttpServletRequest request) throws
IOException {
    int contentLength = request.getContentLength();
    byte contentBytes[] = new byte[contentLength];
    BufferedInputStream bis = new
BufferedInputStream(request.getInputStream());
    try {
      int contentBytesOffset = 0;
      int readLen;
      while ((readLen = bis.read(contentBytes, contentBytesOffset,
          contentLength - contentBytesOffset)) > 0) {
        contentBytesOffset += readLen;
      }
      // TODO: encoding issues?
      return new String(contentBytes);
    } finally {
      bis.close();
    }
  }



http://gwt-code-reviews.appspot.com/727801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors