[gwt-contrib] DynatableRf refactoring in response to http://code.google.com/p/google-web-toolkit/source/detail... (issue674803)

[amitmanjhi]

Reviewers: Ray Ryan,

Description:
DynatableRf refactoring in response to
http://code.google.com/p/google-web-toolkit/source/detail?r=8436
Patch by: amitmanjhi
Review by: rjrjr


Please review this at http://gwt-code-reviews.appspot.com/674803/show

Affected files:
  M  
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
  M  
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/PersonProxy.java


Index:  
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
===================================================================
---  
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java	 
(revision 8442)
+++  
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java	 
(working copy)
@@ -16,10 +16,12 @@
 package com.google.gwt.sample.dynatablerf.client;

 import com.google.gwt.requestfactory.shared.Receiver;
+import com.google.gwt.sample.dynatablerf.shared.DynaTableRequestFactory;
 import com.google.gwt.sample.dynatablerf.shared.PersonProxy;
-import com.google.gwt.sample.dynatablerf.shared.DynaTableRequestFactory;
+import com.google.gwt.valuestore.shared.SyncResult;

 import java.util.List;
+import java.util.Set;

 /**
    * A data provider that bridges the provides row level updates from the  
data
@@ -57,18 +59,18 @@
       // Fetch the data remotely.
       //

-      requests.schoolCalendarRequest().getPeople(startRow, maxRows).to(new  
Receiver<List<PersonProxy>>() {
+      requests.schoolCalendarRequest().getPeople(startRow,  
maxRows).fire(new Receiver<List<PersonProxy>>() {

         // TODO onError call RowDataAcceptor#fail, not yet provided by RF

-        public void onSuccess(List<PersonProxy> response) {
+        public void onSuccess(List<PersonProxy> response, Set<SyncResult>  
syncResults) {
           lastStartRow = startRow;
           lastMaxRows = maxRows;
           lastPeople = response.toArray(new PersonProxy[response.size()]);
           PersonProxy[] result = response.toArray(new  
PersonProxy[response.size()]);
           pushResults(acceptor, startRow, result);
         }
-      }).fire();
+      });
     }

     private void pushResults(RowDataAcceptor acceptor, int startRow,
Index:  
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/PersonProxy.java
===================================================================
---  
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/PersonProxy.java	 
(revision 8442)
+++  
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/PersonProxy.java	 
(working copy)
@@ -33,7 +33,7 @@
   Property<String> description = new  
Property<String>("description", "Description", String.class);
   Property<String> schedule = new Property<String>("schedule", "Schedule",  
String.class);

-  public String getSchedule();
+  String getSchedule();

   String getDescription();



--
http://groups.google.com/group/Google-Web-Toolkit-Contributors