LGTM, just a couple of code style nits I saw re-reading the patch.
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003 File user/src/com/google/gwt/resources/client/DataResource.java (right): http://gwt-code-reviews.appspot.com/714801/diff/48001/6003#newcode35 user/src/com/google/gwt/resources/client/DataResource.java:35: * Specifies the resource or resources associated with the Specifies that the http://gwt-code-reviews.appspot.com/714801/diff/48001/6012 File user/test/com/google/gwt/resources/client/DataResourceDoNotEmbedTest.java (right): http://gwt-code-reviews.appspot.com/714801/diff/48001/6012#newcode22 user/test/com/google/gwt/resources/client/DataResourceDoNotEmbedTest.java:22: * Tests for <code>@link DataResource.DoNotEmbed @DoNotEmbed}</code> resource Check the formatting of that @link. http://gwt-code-reviews.appspot.com/714801/diff/48001/6012#newcode67 user/test/com/google/gwt/resources/client/DataResourceDoNotEmbedTest.java:67: // Skip this test for browsers which do not support data URLs return; here since it's an early out. Remove the else block. Apply in the other test class. http://gwt-code-reviews.appspot.com/714801/diff/48001/6013 File user/test/com/google/gwt/resources/client/DataResourceMimeTypeTest.java (right): http://gwt-code-reviews.appspot.com/714801/diff/48001/6013#newcode22 user/test/com/google/gwt/resources/client/DataResourceMimeTypeTest.java:22: * Tests for <code>@link DataResource.MimeType @MimeType}</code> resource Weird formatting with the @link here. http://gwt-code-reviews.appspot.com/714801/diff/48001/6013#newcode27 user/test/com/google/gwt/resources/client/DataResourceMimeTypeTest.java:27: static interface Resources extends ClientBundle { interfaces are implicitly static http://gwt-code-reviews.appspot.com/714801/diff/48001/6013#newcode34 user/test/com/google/gwt/resources/client/DataResourceMimeTypeTest.java:34: static final String FOUR_ZEROS_SOURCE = "fourZeros.dat"; Remove the "static final" modifiers, since that's implicit. http://gwt-code-reviews.appspot.com/714801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
