http://gwt-code-reviews.appspot.com/669801/diff/33001/34006 File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java (right):
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43 dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:43: Pattern.compile("function |[_a-zA-Z$][.$_a-zA-Z0-9]*=function"); This regex will incorrect match vtable declarations of the form: _.name = function() { ... } These prototype declarations cannot be re-ordered, so don't let it match a single '_' symbol. On 2010/08/05 23:02:48, Alexandre Vassalotti wrote:
On 2010/08/05 19:27:01, zundel wrote: > Wait a minute, what happened to the caret? This means any line with
the
string > "function " in it will match. Is that what we want?
This is not an issue since the lookingAt() method, which matches only
at the
beginning of a string, is used in isFunctionDeclaration().
http://gwt-code-reviews.appspot.com/669801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors