http://gwt-code-reviews.appspot.com/750801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java (right):
http://gwt-code-reviews.appspot.com/750801/diff/1/2#newcode86 dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java:86: Object getCastableTypeMap(); What's the return type? Anything in an .ext package is at least semi-public API. http://gwt-code-reviews.appspot.com/750801/diff/1/4 File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right): http://gwt-code-reviews.appspot.com/750801/diff/1/4#newcode1102 dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java:1102: Extra whitespace. http://gwt-code-reviews.appspot.com/750801/diff/1/6 File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/750801/diff/1/6#newcode1496 dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java:1496: private void generateCastableTypeIds(JClassType x, List<JsStatement> globalStmts) { It's helpful to future maintainers if you add comments that more-or-less correspond to the Java syntax that the AST represents. http://gwt-code-reviews.appspot.com/750801/diff/1/7 File dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Array.java (right): http://gwt-code-reviews.appspot.com/750801/diff/1/7#newcode137 dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Array.java:137: Object castableTypeMap, int queryId, int length, int seedType) { Why is the Object all over the place? http://gwt-code-reviews.appspot.com/750801/diff/1/12 File user/src/com/google/gwt/rpc/server/ClientOracle.java (right): http://gwt-code-reviews.appspot.com/750801/diff/1/12#newcode56 user/src/com/google/gwt/rpc/server/ClientOracle.java:56: public abstract Object getCastableTypeMap(Class<?> clazz); Tighten the return type. http://gwt-code-reviews.appspot.com/750801/diff/1/12#newcode117 user/src/com/google/gwt/rpc/server/ClientOracle.java:117: Extra whitespace. http://gwt-code-reviews.appspot.com/750801/diff/1/17 File user/super/com/google/gwt/emul/java/lang/Object.java (right): http://gwt-code-reviews.appspot.com/750801/diff/1/17#newcode46 user/super/com/google/gwt/emul/java/lang/Object.java:46: * lookup castability between types Describe the structure of this object. Is it a JSO? http://gwt-code-reviews.appspot.com/750801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
