http://gwt-code-reviews.appspot.com/755801/diff/5001/6006 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java (right):
http://gwt-code-reviews.appspot.com/755801/diff/5001/6006#newcode24 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java:24: public static Person findPerson(Long id) { Yes, and will stay at least semi-magical. Our plan is to allow you to provide a factory to the RFServlet: interface RequestFactoryServletHelper { <T> T findInstance(Class<T> clazz, Object id); <T> T findService(Class<T> clazz); } The default implementation will do what you see now: every proxied type is required to provide a static finder method so that we can pick up instances to muck with. On 2010/08/12 13:48:12, bobv wrote:
Is this another magic method?
http://gwt-code-reviews.appspot.com/755801/diff/5001/6007 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/SchoolCalendarService.java (right): http://gwt-code-reviews.appspot.com/755801/diff/5001/6007#newcode91 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/SchoolCalendarService.java:91: public static Person findPerson(Long id) { Ditto On 2010/08/12 13:48:12, bobv wrote:
Magic?
http://gwt-code-reviews.appspot.com/755801/diff/5001/6007#newcode99 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/server/SchoolCalendarService.java:99: person.setVersion(person.getVersion() + 1); Vestigial requirement. Unused, and slated to be relaxed for M4. Will put a TODO to that effect. On 2010/08/12 13:48:12, bobv wrote:
Is this version stuff important to the sample, or a holdover from a
JPA-style
sample?
http://gwt-code-reviews.appspot.com/755801/diff/5001/6008 File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/DynaTableRequestFactory.java (right): http://gwt-code-reviews.appspot.com/755801/diff/5001/6008#newcode37 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/DynaTableRequestFactory.java:37: @Instance Yes. On 2010/08/12 13:48:12, bobv wrote:
This means that the method should be invoked on the instance of the
first
argument?
http://gwt-code-reviews.appspot.com/755801/diff/5001/6008#newcode50 samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/shared/DynaTableRequestFactory.java:50: PersonRequest personRequest(); Yes, I think. I've never really been certain what a vtable is. On 2010/08/12 13:48:12, bobv wrote:
So the PersonRequest interface is almost like a vtable for remote
calls? It
just has a bunch of method stubs to queue up operations on?
http://gwt-code-reviews.appspot.com/755801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
